-
-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate webostv to new library and make integration async with callback state updates #29296
Conversation
for generic commands, input/button commands, and callback state updates
"""Request configuration steps from the user.""" | ||
host = conf.get(CONF_HOST) | ||
name = conf.get(CONF_NAME) | ||
configurator = hass.components.configurator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The configurator is deprecated. To keep this PR at a minimum it's ok to keep the configurator for now. Preferably a follow up PR would be done where it's replaced with a config flow.
Hi there. Will this support audio output selection? I’ve been trying to find a solution for that. |
Update webostv documentation follwing changes in home-assistant/core#29296
Update webostv documentation following changes in home-assistant/core#29296
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great!
Are we ready to merge?
Please update the breaking change paragraph to mention the removal of some of the config options and that host is required. |
Indeed this should be ready to merge now. |
Description:
migrate webostv to new aiopylgtv version of the library and make the integration asynchronous with callback state updates
Breaking Change:
Since the connection handling has become non-trivial, it is now moved to init.py to be shared between the media_player and notify platforms, so the component setup now has to be done from the webostv domain instead of in media_player. The host configuration option is now required (as auto-discovery was anyways not functional) and the timeout and filename options have been removed as there is no real need to change the defaults.
Example entry for
configuration.yaml
(if applicable):Corresponding documentation update in home-assistant/home-assistant.io#11584